feat: Adding StringJoiner #8357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
type:documentation
Pull Request Test Coverage Report for Build 11595719661Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Hey @silvanocerza this is one of the PR's that contains a pipeline behavioral test that fails currently but works in your subgraphs branch. |
|
Once this PR #8431 is merged then the component in this PR will work and be ready for review. |
sjrl
requested review from
dfokina and
anakin87
and removed request for
a team
anakin87
reviewed
Oct 30, 2024
There was a problem hiding this comment.
Other than minor improvements, it looks good.
I would also like @silvanocerza to take a quick look.
silvanocerza
approved these changes
Oct 30, 2024
Co-authored-by: Stefano Fiorucci <[email protected]>
Co-authored-by: Stefano Fiorucci <[email protected]>
|
Thanks @anakin87 ! I'll add a usage example. |
|
@dfokina this component will probably go in 2.7.0 and we should create a simple doc page for it. |
anakin87
approved these changes
Oct 30, 2024
Co-authored-by: Stefano Fiorucci <[email protected]>
silvanocerza
added a commit
that referenced
this pull request
Oct 30, 2024
* Adding StringJoiner * Release notes * Remove typing * Remove unused import * Try to fix header * Fix one test * Add to docs, move test to behavioral pipeline test * Undo changes * Fix test * Update haystack/components/joiners/string_joiner.py Co-authored-by: Stefano Fiorucci <[email protected]> * Update haystack/components/joiners/string_joiner.py Co-authored-by: Stefano Fiorucci <[email protected]> * Provide usage example * Apply suggestions from code review Co-authored-by: Stefano Fiorucci <[email protected]> --------- Co-authored-by: Stefano Fiorucci <[email protected]> Co-authored-by: Silvano Cerza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
StringJoineras a convenience component #8353Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.