Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pipeline skipping a Component with Variadic input #8347

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

silvanocerza
Copy link
Contributor

Related Issues

Proposed Changes:

Fix a bug that would cause Components with Variadic input not to run if one of its senders doesn't send it any input.

If other Components sent it some inputs the Compoent with Variadic input should ideally run in any case.

How did you test it?

I added a new behavioural test and updated existing unit tests.

Notes for the reviewer

I'll draft a patch release after this is merged.

Checklist

@silvanocerza silvanocerza self-assigned this Sep 9, 2024
@silvanocerza silvanocerza requested review from a team as code owners September 9, 2024 15:55
@silvanocerza silvanocerza requested review from dfokina, Amnah199 and shadeMe and removed request for a team September 9, 2024 15:55
@coveralls
Copy link
Collaborator

coveralls commented Sep 9, 2024

Pull Request Test Coverage Report for Build 10789463919

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 90.328%

Files with Coverage Reduction New Missed Lines %
core/pipeline/base.py 1 92.39%
Totals Coverage Status
Change from base Build 10774951533: 0.02%
Covered Lines: 7154
Relevant Lines: 7920

💛 - Coveralls

@silvanocerza silvanocerza merged commit 4d67b55 into main Sep 10, 2024
18 checks passed
@silvanocerza silvanocerza deleted the fix-variadics-not-running branch September 10, 2024 12:59
silvanocerza added a commit that referenced this pull request Sep 10, 2024
* Fix Pipeline skipping a Component with Variadic input

* Simplify _find_components_that_will_receive_no_input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component with Variadic input is not run if some of its inputs are not sent
3 participants