Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: route not identified files to dead end edge #7589

Merged

Conversation

ArzelaAscoIi
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi commented Apr 24, 2024

Related Issues

Proposed Changes:

  • route not identified file to dead end.

How did you test it?

  • not yet. First want to validate that this is feasible solution

Notes for the reviewer

Failed to index because of: 'Exception while running node 'FileTypeClassifier': 'NoneType' object has no attribute 'get'
Enable debug logging to see the data that was passed when the pipeline failed.'. Skipping handling indexing requests.

AttributeError: 'NoneType' object has no attribute 'get'
/opt/venv/lib/python3.10/site-packages/haystack/pipelines/base.py, line 567, run
/opt/venv/lib/python3.10/site-packages/haystack/pipelines/base.py, line 469, _run_node
/opt/venv/lib/python3.10/site-packages/haystack/nodes/base.py, line 201, _dispatch_run
/opt/venv/lib/python3.10/site-packages/haystack/nodes/base.py, line 257, _dispatch_run_general

Caused by:
Exception: Exception while running node 'FileTypeClassifier': 'NoneType' object has no attribute 'get'
Enable debug logging to see the data that was passed when the pipeline failed.
/opt/venv/lib/python3.10/site-packages/dc_consumer_indexing/indexing_service.py, line 79, handle_indexing_queue
/opt/venv/lib/python3.10/site-packages/dc_consumer_indexing/indexing_service.py, line 216, _batch_index_file
/opt/venv/lib/python3.10/site-packages/dc_consumer_indexing/gateways/haystack/local.py, line 170, batch_index
/opt/venv/lib/python3.10/site-packages/dc_consumer_indexing/gateways/haystack/local.py, line 90, _index
/opt/venv/lib/python3.10/site-packages/haystack/pipelines/base.py, line 574, run

@ArzelaAscoIi ArzelaAscoIi requested a review from a team as a code owner April 24, 2024 10:20
@ArzelaAscoIi ArzelaAscoIi requested review from shadeMe and removed request for a team April 24, 2024 10:20
@shadeMe shadeMe requested review from vblagoje and removed request for shadeMe April 24, 2024 10:30
@vblagoje
Copy link
Member

Looks good @ArzelaAscoIi , let's wait for CI to complete

@ArzelaAscoIi ArzelaAscoIi merged commit 7479db0 into deepset-ai:v1.x Apr 24, 2024
49 checks passed
@ArzelaAscoIi ArzelaAscoIi deleted the fix/returnNoneForNotIdentifiedFile branch April 24, 2024 12:49
vblagoje pushed a commit that referenced this pull request Apr 24, 2024
* fix: route not identified files to dead end edge

* tests: fix unit tests

* tests: add file classifier pipeline run

* fix: typing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants