Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OutputParser when used within PromptTemplate #7587

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix: OutputParser when used within PromptTemplate #7587

merged 2 commits into from
Apr 23, 2024

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Apr 23, 2024 •
edited
Loading

Related Issues

  • fixes #issue-number

Proposed Changes:

How did you test it?

  • enabled and ran all skipped tests of test_prompt_node.py

Notes for the reviewer

Checklist

@tstadel tstadel requested a review from a team as a code owner April 23, 2024 16:58
@tstadel tstadel requested review from vblagoje and removed request for a team April 23, 2024 16:58
@tstadel tstadel changed the title Fix/output_parser_invocation_context fix: OutputParser when used within PromptTemplate Apr 23, 2024
@tstadel tstadel requested a review from a team as a code owner April 23, 2024 17:34
@tstadel tstadel requested review from dfokina and removed request for a team April 23, 2024 17:34
@vblagoje vblagoje merged commit b45ecb3 into v1.x Apr 23, 2024
22 checks passed
@vblagoje vblagoje deleted the fix/output_parser_invocation_context branch April 23, 2024 17:35
vblagoje pushed a commit that referenced this pull request Apr 23, 2024
@tstadel @vblagoje
fix: OutputParser when used within PromptTemplate (#7587)
5618d1e 
* fix: extracting results from OutputParser

* add reno
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:LLM topic:promptnode topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tstadel @vblagoje