feat: support Llama3 models on Bedrock #7581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstadel
requested review from
dfokina and
julian-risch
and removed request for
a team
tstadel
changed the title
vblagoje
reviewed
Apr 23, 2024
| @@ -258,7 +258,7 @@ class AmazonBedrockInvocationLayer(AWSBaseInvocationLayer): | |||
| r"ai21.j2.*": AI21LabsJurassic2Adapter, | |||
| r"cohere.command.*": CohereCommandAdapter, | |||
| r"anthropic.claude.*": AnthropicClaudeAdapter, | |||
| r"meta.llama2.*": MetaLlama2ChatAdapter, | |||
| r"meta.llama.*": MetaLlama2ChatAdapter, | |||
There was a problem hiding this comment.
Do we need this . here before *?
There was a problem hiding this comment.
Yes it's a regex match all char. Bit ugly because of the other dots, but we also added tests.
vblagoje
approved these changes
Apr 23, 2024
vblagoje
pushed a commit
that referenced
this pull request
Apr 23, 2024
* feat: support llama3 on bedrock * add reno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.