-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new LLMEvaluator component #7401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
2.x
Related to Haystack v2.0
type:documentation
Improvements on the docs
labels
Mar 21, 2024
Pull Request Test Coverage Report for Build 8411689560Details
💛 - Coveralls |
julian-risch
requested review from
dfokina,
davidsbatista and
shadeMe
and removed request for
a team and
davidsbatista
March 21, 2024 21:16
shadeMe
suggested changes
Mar 22, 2024
shadeMe
suggested changes
Mar 22, 2024
shadeMe
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work 🎉 Good to merge after fixing the lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
An open question currently is how to enforce proper json formatting in the rendered prompt template. Main issue I see is " or ' being used inconsistently and thus maybe causing worse generated results.
Current output is
{'score': 1, 'name': 'llm'}
in the style of the evaluation framework integrations.We can make
llm
customizable as an additional parameter ofLLMEvaluator
later if it makes sense or leave it out completely.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.