Fix deepset logo rendering on pypi.org #7387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rendering images on pypi.org does not work with relative URLs. I changed it to use an absolute link for Deepset's logo.
kacperlukawski
requested review from
dfokina and
masci
and removed request for
a team
|
|
masci
pushed a commit
that referenced
this pull request
Mar 20, 2024
Rendering images on pypi.org does not work with relative URLs. I changed it to use an absolute link for Deepset's logo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Rendering images on pypi.org does not work with relative URLs. I changed it to use an absolute link for Deepset's logo.
Right now it's being rendered like this: