-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce SparseEmbedding
#7382
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
from typing import List, TypedDict | ||
|
||
|
||
class SparseEmbedding: | ||
""" | ||
Class representing a sparse embedding. | ||
""" | ||
|
||
def __init__(self, indices: List[int], values: List[float]): | ||
""" | ||
:param indices: List of indices of non-zero elements in the embedding. | ||
:param values: List of values of non-zero elements in the embedding. | ||
|
||
:raises ValueError: If the indices and values lists are not of the same length. | ||
""" | ||
if len(indices) != len(values): | ||
raise ValueError("Length of indices and values must be the same.") | ||
self.indices = indices | ||
self.values = values | ||
|
||
def to_dict(self): | ||
return {"indices": self.indices, "values": self.values} | ||
|
||
@classmethod | ||
def from_dict(cls, sparse_embedding_dict): | ||
return cls(indices=sparse_embedding_dict["indices"], values=sparse_embedding_dict["values"]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import pytest | ||
|
||
from haystack.dataclasses.sparse_embedding import SparseEmbedding | ||
|
||
|
||
class TestSparseEmbedding: | ||
def test_init(self): | ||
se = SparseEmbedding(indices=[0, 2, 4], values=[0.1, 0.2, 0.3]) | ||
assert se.indices == [0, 2, 4] | ||
assert se.values == [0.1, 0.2, 0.3] | ||
|
||
def test_init_with_wrong_parameters(self): | ||
with pytest.raises(ValueError): | ||
SparseEmbedding(indices=[0, 2], values=[0.1, 0.2, 0.3, 0.4]) | ||
|
||
def test_to_dict(self): | ||
se = SparseEmbedding(indices=[0, 2, 4], values=[0.1, 0.2, 0.3]) | ||
assert se.to_dict() == {"indices": [0, 2, 4], "values": [0.1, 0.2, 0.3]} | ||
|
||
def test_from_dict(self): | ||
se = SparseEmbedding.from_dict({"indices": [0, 2, 4], "values": [0.1, 0.2, 0.3]}) | ||
assert se.indices == [0, 2, 4] | ||
assert se.values == [0.1, 0.2, 0.3] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This differs a bit from the other ones to not alter the id of existing Documents.
I can change it if you think it's better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! This approach looks good to me 👍