bug: run parameter "ranking_mode" does not override init param in meta field ranker

[mohitlal31]

Related Issues

• fixes run parameter "ranking_mode" does not override init param in metafield ranker #7354

Proposed Changes:

The _merge_rankings method uses the self.ranking_mode value initialized in the constructor.
If this value is overridden in the run method, the new ranking_mode is not considered for ranking calculations. Added an extra param to _merge_rankings to accept the updated ranking_mode value that is passed in the run method.

How did you test it?

Added a unit test

Notes for the reviewer

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
• I documented my code
• I ran pre-commit hooks and fixed any issue

[coveralls]

Pull Request Test Coverage Report for Build 8330793362

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 89.204%

---

Totals
Change from base Build 8326632443:	0.0%
Covered Lines:	5371
Relevant Lines:	6021

---

💛 - Coveralls

[sjrl]

Thanks for making a quick fix on this!

[sjrl]

Let's update to use pytest.approx so something like

Suggested change

	assert docs_after[0].score == 0.01626123744050767
	assert docs_after[0].score == pytest.approx(0.016261, abs=1e-5)

since doing float comparisons to that many decimals can be fragile.

[sjrl]

Once the test is updated this looks good to go!

[mohitlal31]

Done

[sjrl]

Thanks!