-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: default for max_new_tokens to 512 in Hugging Face generators #7370
refactor: default for max_new_tokens to 512 in Hugging Face generators #7370
Conversation
Pull Request Test Coverage Report for Build 8330363069Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me! 👍 @CKeibel Thank you for your contribution to Haystack. I just adjusted four tests to make them pass and slightly changed the release note.
The changes to the import statements were added by the pre-commit hooks and they are correct. The change is just about the sorting of the imports.
Congratulations! Looking forward to more PRs from you! 🙂
Hey @CKeibel have you already signed the contributor license agreement? Before we can merge your PR, we need you to sign it please: #7370 (comment) |
Yes, I signed it on Friday but somehow it doesn't seem to update. But I can have another look :) |
Apparently my local git setting must have been wrong, the user who made the commits is called |
Hey @julian-risch , apparently I have to edit my commits with a rebase. I'll do that later when I get home from work. |
1aa4d95
to
656a1cf
Compare
656a1cf
to
290133e
Compare
#7370) * set default for max_new_tokens to 512 in Hugging Face generators * add release notes * fix tests * remove issues from release note --------- Co-authored-by: christopherkeibel <[email protected]> Co-authored-by: Julian Risch <[email protected]>
Related Issues
max_new_tokens
#7365Proposed Changes:
max_new_tokens
to515
in "Hugging Face generators".How did you test it?
Initialization tests had already been implemented but were adjusted based on the change.
Notes for the reviewer
There were several tests that were adjusted differently. I hope that the changes are correct, otherwise I will fix them as soon as possible.
There have been changes to the imports that I did not add on my own (I don't know if the pre-commit hooks can influence this or where they come from). If these seem strange, I will fix them as soon as possible.