Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: review all extra #6029

Merged
merged 10 commits into from
Oct 12, 2023
Merged

chore: review all extra #6029

merged 10 commits into from
Oct 12, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Oct 11, 2023 •
edited
Loading

Related Issues

  • fixes failing CI

Proposed Changes:

Removes the audio, ray, onnx and beir extras from the extra group all due to dependency conflicts between openai-whisper and other components that require torch.

How did you test it?

CI

Notes for the reviewer

I marked this change as breaking, even though hopefully the impact should be minimal.

I checked mainly CI workflows and Docker images. Please help me make sure we're not forgetting some other usage of the all extra.

Checklist

@ZanSara ZanSara marked this pull request as ready for review October 11, 2023 15:19
@ZanSara ZanSara requested a review from a team as a code owner October 11, 2023 15:19
@ZanSara ZanSara requested review from silvanocerza and removed request for a team October 11, 2023 15:19
@ZanSara ZanSara requested a review from a team as a code owner October 11, 2023 15:19
@ZanSara ZanSara requested review from dfokina and masci and removed request for a team, silvanocerza and dfokina October 11, 2023 15:19
masci
masci approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@masci masci force-pushed the review-all-extras branch from 36359a8 to b8c62d0 Compare October 12, 2023 10:43
@coveralls
Copy link
Collaborator

coveralls commented Oct 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6497358658

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on review-all-extras at 50.408%
Totals Coverage Status
Change from base Build 6495236394: 50.4%
Covered Lines: 12674
Relevant Lines: 25143
💛 - Coveralls

@github-actions github-actions bot added the type:documentation Improvements on the docs label Oct 12, 2023
@masci masci force-pushed the review-all-extras branch from ec9b2b1 to 61a72bd Compare October 12, 2023 14:55
@masci masci force-pushed the review-all-extras branch from 61a72bd to 15a2a60 Compare October 12, 2023 14:57
@anakin87 anakin87 mentioned this pull request Oct 12, 2023
Merged
@anakin87
Copy link
Member

🎉

@masci masci merged commit adf7e49 into main Oct 12, 2023
63 checks passed
@masci masci deleted the review-all-extras branch October 12, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
topic:build/distribution topic:CI topic:dependencies topic:pipeline topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZanSara @coveralls @anakin87 @masci