-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Run update_embeddings in examples #6008
Conversation
Added an example about hybrid search for faq pipeline on covid dataset
added test for hybrid search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nickprock Thanks for adding this fix and I see you already merged Haystack main just now. Before, the PR was still based on the version of July. 👍
Let's change the release notes so that the PR note is listed under fixes
. We use upgrade
for breaking changes with guidelines how to upgrade. Something like Added documents_store.update_embeddings to hybrid search example pipeline.
under fixes
would be great!
@nickprock In the failing test you see that we also updated precommit hooks since last time. |
Pull Request Test Coverage Report for Build 6470518728
💛 - Coveralls |
Hi @julian-risch I hope now it's correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for this contribution. 👍 We should have noticed earlier ourselves but thanks to you it's fixed now. I'll merge the pull request as soon as all the test passed.
Proposed Changes:
example-document
. Otherwise by running the example, users might delete their default indexdocument
with their own dataanthropic
was missing intest_getting_started
parameterized testHow did you test it?
manual verification, CI
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.