-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adding missing docstrings for run and run_batch methods #5609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
I noticed some small aspects to improve...
@anakin87 Also, black tests keep failing with each commit, what can I do with that? |
Two alternative solutions (the first is better)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left only a small comment. (Not sure if relevant)
Once the tests are green, we can merge this!
I tried to fix black errors. |
Pull Request Test Coverage Report for Build 6506193085
💛 - Coveralls |
Related Issues
Proposed Changes:
run
andrun_batch
methods in several nodes.How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.