Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vLLM integration page #182

Merged
merged 2 commits into from
Feb 16, 2024
Merged

update vLLM integration page #182

merged 2 commits into from
Feb 16, 2024

Conversation

anakin87
Copy link
Member

fixes #161

@anakin87 anakin87 requested a review from a team as a code owner February 16, 2024 12:15
@anakin87 anakin87 requested a review from bilgeyucel February 16, 2024 12:15
bilgeyucel
bilgeyucel approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I left one small comment, you also need to add version: Haystack 2.0 to the frontmatter.

integrations/vllm.md Outdated Show resolved Hide resolved
@anakin87 anakin87 merged commit 998b6e1 into main Feb 16, 2024
@anakin87 anakin87 deleted the vllm-add-2.x-section branch February 16, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilgeyucel bilgeyucel bilgeyucel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update vLLM integration page
2 participants
@anakin87 @bilgeyucel