Formatters update #457
Open
Formatters update #457
+910
−745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoIsALie
force-pushed
the
feat/formatter-upd
branch
2 times, most recently
from
7e3c27f
to
ebe504a
Compare
NeoIsALie
force-pushed
the
feat/formatter-upd
branch
from
760d51e
to
d7a5be5
Compare
Kpetyxova
requested changes
Jun 27, 2023
NeoIsALie
force-pushed
the
feat/formatter-upd
branch
from
65e7254
to
06f3a1e
Compare
NeoIsALie
force-pushed
the
feat/formatter-upd
branch
from
ae6d9ac
to
6641df7
Compare
NeoIsALie
force-pushed
the
feat/formatter-upd
branch
from
b76fd0d
to
50548bd
Compare
dilyararimovna
requested changes
Sep 24, 2023
|
Test Dialog. Если смотреть логи, то там ошибки из-за форматтеров. 
|
dilyararimovna
requested changes
Nov 7, 2023
| elif service_name == "summarization-annotator": | ||
| return get_sents(dialog) | ||
| else: | ||
| return dialog |
There was a problem hiding this comment.
<img width="1420" alt="Screenshot 2023-11-07 at 13 14 38"
src="https://github.com/deeppavlov/dream/assets/14152126/84651f39-666d-4822-8c25-f345f4c011c0">
в форматтерах подразумевается, что форматтер так и так возвращает батч (просто из одного элемента) -- искусственно оборачивает в лист. А ты как будто где-то это делаешь, а где-то нет. Провреь, пожалуйста -- ошибка в тестах из-за этого 100 %
There was a problem hiding this comment.
Хорошо, я посмотрю.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly decrease number of formatters used in Dream. Modified formatters use similar logic with minor differences. Deleted all unused functions.