-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service option update #378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to from_script() before, that's not handled right now)
…ced TOY_SCRIPT_ARGS with TOY_SCRIPT_KWARGS
…uted_fields from Pipeline, they're not working as intended
This is error-prone and not needed.
Now renaming does not happen if there are no collisions; Postfix is added with "#" to further avoid collisions.
Use add_extra_handler on group instead
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ServiceGroup
s can now run async components in groups within itself, instead of not doing that if there's even one sequential component inside. This removes the need to make lots of ServiceGroups just to run some functions in parallel.Basically, [a, s, a, a, s] -> a, s, (a, a), s, where 'a' and 's' are 'asynchronous' and 'sequential' components respectively. So, it's easier to define async components in
ServiceGroups
now. The user can mark any of them as asynchronous, by default all PipelineComponents are sequential except theActor
.ServiceGroup
s that contain a component with 'sequential' = True. True, the user can make a mistake, but it allows for the program to be faster, so it's a reasonable tradeoff.PipelineComponent
__call__
signature to(ctx: Context) -> None
-- since 'Core Rework'Pipeline
can be accessed fromContext
; component info should be obtained fromself
via subclassing fromService
and defining a customcall(self, ctx: Context)
method.BaseProcessing
is also accepted in place of theservice.handler
(Service
,ServiceGroup
andActor
are all instances ofPipelineComponent
)BaseCondition
-- able to reuse built-in conditions for servicesservice_successful_condition
toServiceFinished
condition which awaits until the service is either finished or failed.pipeline._run_pipeline()
just to be safe.Service
test coverage to 100%.Checklist
Service
test coverage done.To Consider
Service
fromBaseProcessing
.Extra Handlers
could just be made intoService
s. (I think it'd take a lot of time to change now and I also thinkExtra Handlers
do have some value).ignore
files, scripts (such aslint
), distribution manifest (if files are added/deleted)