Skip to content

Commit

Permalink
pv should not be multiplied by 3 because it is not water
Browse files Browse the repository at this point in the history
  • Loading branch information
Yi-FanLi committed Aug 6, 2024
1 parent e694f2c commit f64d7f3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dpti/hti.py
Original file line number Diff line number Diff line change
Expand Up @@ -1301,7 +1301,7 @@ def compute_task(
v = npt_info["v"]

Check warning on line 1301 in dpti/hti.py

View check run for this annotation

Codecov / codecov/patch

dpti/hti.py#L1300-L1301

Added lines #L1300 - L1301 were not covered by tests
v_err = npt_info["v_err"]
unit_cvt = 1e5 * (1e-10**3) / pc.electron_volt
pv = p * v * unit_cvt * 3
pv = p * v * unit_cvt
pv_err = p * v_err * unit_cvt * np.sqrt(3)
print(f"# use pv from npt task: pv = {pv:.6e} pv_err = {pv_err:.6e}")
elif npt is None and manual_pv is None:

Check warning on line 1307 in dpti/hti.py

View check run for this annotation

Codecov / codecov/patch

dpti/hti.py#L1303-L1307

Added lines #L1303 - L1307 were not covered by tests
Expand Down
2 changes: 1 addition & 1 deletion dpti/hti_liq.py
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ def compute_task(
v = npt_info["v"]
v_err = npt_info["v_err"]
unit_cvt = 1e5 * (1e-10**3) / pc.electron_volt
pv = p * v * unit_cvt * 3
pv = p * v * unit_cvt
pv_err = p * v_err * unit_cvt * np.sqrt(3)
print(f"# use pv from npt task: pv = {pv:.6e} pv_err = {pv_err:.6e}")
elif npt is None and manual_pv is None:

Check warning on line 520 in dpti/hti_liq.py

View check run for this annotation

Codecov / codecov/patch

dpti/hti_liq.py#L504-L520

Added lines #L504 - L520 were not covered by tests
Expand Down

0 comments on commit f64d7f3

Please sign in to comment.