-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HDF5 support for trajs and model_devis #259
Changes from all commits
f539428
864dcf9
93e508c
18d2b70
c90e5dd
1666e91
6acdbef
ea87d06
16c30d6
0e36fb5
6e7e795
967ade6
a8e82ab
5e2c2eb
687b9c5
ee022f7
0499be9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,10 +9,14 @@ | |
List, | ||
Optional, | ||
Tuple, | ||
Union, | ||
) | ||
|
||
import dpdata | ||
import numpy as np | ||
Comment on lines
15
to
16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove unused imports. The static analysis tool suggests that the following imports are unused:
Please remove these unused imports to keep the code clean. ToolsRuff
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems ruff hasn't been enabled in the dpgen2 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @njzjz, you're correct that Ruff hasn't been enabled in the |
||
from dflow.python.opio import ( | ||
HDF5Dataset, | ||
) | ||
|
||
from dpgen2.exploration.render import ( | ||
TrajRender, | ||
|
@@ -52,8 +56,8 @@ def __init__( | |
|
||
def select( | ||
self, | ||
trajs: List[Path], | ||
model_devis: List[Path], | ||
trajs: Union[List[Path], List[HDF5Dataset]], | ||
model_devis: Union[List[Path], List[HDF5Dataset]], | ||
type_map: Optional[List[str]] = None, | ||
optional_outputs: Optional[List[Path]] = None, | ||
) -> Tuple[List[Path], ExplorationReport]: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,7 @@ | |
) | ||
from .run_relax import ( | ||
RunRelax, | ||
RunRelaxHDF5, | ||
) | ||
from .select_confs import ( | ||
SelectConfs, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused import.
The
dpdata
module is imported but unused.Apply this diff to remove the unused import:
-import dpdata
Committable suggestion
Tools
Ruff