Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load files according to filename suffix #1255

Merged
merged 4 commits into from
Jun 25, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jun 22, 2023

The current try...catch does not report what's wrong in the YAML file if it is invalid.

njzjz and others added 2 commits June 18, 2023 13:41
The current `try...catch` does not report what's wrong in the YAML file if it is invalid.

Signed-off-by: Jinzhe Zeng <[email protected]>
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 51.85% and project coverage change: +0.19 🎉

Comparison is base (84f64dd) 47.63% compared to head (a330e3c) 47.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1255      +/-   ##
==========================================
+ Coverage   47.63%   47.82%   +0.19%     
==========================================
  Files          82       82              
  Lines       14588    14544      -44     
==========================================
+ Hits         6949     6956       +7     
+ Misses       7639     7588      -51     
Impacted Files Coverage Δ
dpgen/data/reaction.py 0.00% <0.00%> (ø)
dpgen/generator/run.py 66.57% <0.00%> (+0.18%) ⬆️
dpgen/data/gen.py 52.03% <33.33%> (+0.45%) ⬆️
dpgen/data/surf.py 72.16% <33.33%> (+1.59%) ⬆️
dpgen/simplify/simplify.py 22.18% <33.33%> (+0.13%) ⬆️
dpgen/util.py 94.56% <91.66%> (-0.44%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@njzjz njzjz requested a review from wanghan-iapcm June 23, 2023 23:21
@wanghan-iapcm wanghan-iapcm merged commit 930f605 into deepmodeling:devel Jun 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants