Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #359: reading atom names from POTCAR lines in OUTCAR #361

Closed
wants to merge 0 commits into from

Conversation

hoba87
Copy link

@hoba87 hoba87 commented Sep 30, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.05 🎉

Comparison is base (0db9246) 82.15% compared to head (59b6ecc) 82.20%.

❗ Current head 59b6ecc differs from pull request most recent head d632f51. Consider uploading reports for the commit d632f51 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #361      +/-   ##
==========================================
+ Coverage   82.15%   82.20%   +0.05%     
==========================================
  Files          66       67       +1     
  Lines        5784     5896     +112     
==========================================
+ Hits         4752     4847      +95     
- Misses       1032     1049      +17     
Impacted Files Coverage Δ
dpdata/vasp/outcar.py 95.58% <80.00%> (-1.08%) ⬇️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hoba87
Copy link
Author

hoba87 commented Sep 30, 2022

fixes #359

dpdata/vasp/outcar.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants