First stage of add DSP FFT #5878
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanchen
reviewed
Jan 26, 2025
| @@ -65,6 +67,12 @@ void FFT_Bundle::initfft(int nx_in, | |||
|
|
|||
| if (device=="cpu") | |||
| { | |||
| #if defined(__DSP) | |||
| if (float_flag==true) | |||
| ModuleBase::WARNING_QUT("device","now dsp fft is not support for the float type"); | |||
There was a problem hiding this comment.
add {} for if (float_flag==true)
| PLAN* ptr_plan_forward; | ||
| PLAN* ptr_plan_backward; | ||
| INT num_thread=8; | ||
| INT size; |
There was a problem hiding this comment.
initialize the variable
| @@ -22,6 +22,9 @@ PW_Basis_K::~PW_Basis_K() | |||
| delete[] igl2isz_k; | |||
| delete[] igl2ig_k; | |||
| delete[] gk2; | |||
| #if defined(__DSP) | |||
| delete[] ig2ixyz_k_cpu; | |||
There was a problem hiding this comment.
it's dangeruous to use delte[] with #if, cold you change ig2ixyz_k_cpu to std::vector?
There was a problem hiding this comment.
Certainly, I shall make the necessary amendments to it.
mohanchen
added
GPU & DCU & HPC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACHIEVEMENT
When compiling ABACUS with the DSP=ON option, the software automatically configures the FFT device to utilize DSP. This configuration demonstrates significant performance improvements, achieving over 30 times the speed compared to the FT cluster. Additionally, it exhibits strong scalability.I would like to acknowledge the contributions of the author of the mt_3d_fft library and extend my gratitude to @Qianruipku for their valuable input. Special thanks are also due to @mohanchen for significant support .Due to the check of the compuer ,i temporarially add the first stage of the DSP FFT.
Attention
1.FUNCTION:This is not the final step in porting DSP computations. After specifying MT_FFT_LIBRARY, MT_FFT_INCLUDE, and MT_HRHREAD, the DSP can be utilized to compute FFT. Currently, simultaneous use of DSP FFT and BLAS is not supported. Features for this will be promptly added.
2.PERFOMANCE: At present, the DSP FFT does not achieve its fastest performance, as some memory copies have not yet been optimized. This aspect will also be optimized in the future.Some functions in real_to_recip do not utilize memcpy or zapy_. These functions could be optimized or potentially moved to the DSP for improved performance.
What's changed?