Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skip_special_tokens flag #907

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Fix skip_special_tokens flag #907

merged 1 commit into from
Jul 5, 2023

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented Jul 5, 2023

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@xyang16 xyang16 requested review from zachgk, frankfliu and a team as code owners July 5, 2023 21:36
@xyang16 xyang16 requested a review from lanking520 July 5, 2023 21:47
@lanking520 lanking520 merged commit 5923314 into deepjavalibrary:master Jul 5, 2023
8 checks passed
siddvenk pushed a commit to siddvenk/djl-serving that referenced this pull request Jul 6, 2023
@xyang16 @siddvenk
Fix skip_special_tokens flag (deepjavalibrary#907)
18858be
KexinFeng pushed a commit to KexinFeng/djl-serving-forked that referenced this pull request Aug 16, 2023
@xyang16
Fix skip_special_tokens flag (deepjavalibrary#907)
292ae9a
KexinFeng pushed a commit to KexinFeng/djl-serving-forked that referenced this pull request Aug 16, 2023
@xyang16 @KexinFeng
Fix skip_special_tokens flag (deepjavalibrary#907)
f18e95f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@frankfliu frankfliu frankfliu approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xyang16 @lanking520 @frankfliu