Add quantization parameter for lmi_dist rolling batch backend for HF
#888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindhuvahinis
approved these changes
Jun 30, 2023
lanking520
suggested changes
Jun 30, 2023
|
can you also add to FasterTransformer container for this bitsandbytes flag? |
@lanking520 Done |
lanking520
previously approved these changes
Jul 3, 2023
lanking520
reviewed
Jul 3, 2023
| sharded=sharded, | ||
| quantize=None, | ||
| trust_remote_code=kwargs.get("trust_remote_code")) | ||
| quantize = self.properties.get("quantize", None) |
There was a problem hiding this comment.
in the original properties, we have option.load_in_8bit, can we reuse this param?
There was a problem hiding this comment.
load_in_8bit is a boolean. Assuming we add gptq support in next release we need a parameter which can take the quantization algo name instead of just a boolean. @lanking520 thoughts?
frankfliu
reviewed
Jul 6, 2023
frankfliu
approved these changes
Jul 6, 2023
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
deepjavalibrary#888) * Set quantization param from properties file * Format python * Set quantize if dtype==int8 * Address review comments * Adding BITSANDBYTES_NOWELCOME flag to fastertransformer * Add back
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
deepjavalibrary#888) * Set quantization param from properties file * Format python * Set quantize if dtype==int8 * Address review comments * Adding BITSANDBYTES_NOWELCOME flag to fastertransformer * Add back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables setting
quantizefrom properties for the lmi_dist rolling batch backend