Raise inference failure exceptions in default handlers #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddvenk
approved these changes
Jun 29, 2023
frankfliu
reviewed
Jun 29, 2023
| @@ -368,7 +368,7 @@ def inference(self, inputs: Input): | |||
| outputs.add_property("content-type", "application/json") | |||
| except Exception as e: | |||
| logging.exception("DeepSpeed inference failed") | |||
| outputs = Output().error((str(e))) | |||
| raise e | |||
There was a problem hiding this comment.
If we rethrow the exception, we don't need to catch it at the first place
There was a problem hiding this comment.
yeah, I thought about it too. I did not remove it as I was not sure if the log statement right above provided any value.
There was a problem hiding this comment.
the exception will be caught at higher level and will be logged there
frankfliu
approved these changes
Jun 30, 2023
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
…ry#883) * raise inference failure exceptions in default handlers
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
…ry#883) * raise inference failure exceptions in default handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently inference failure exceptions are suppressed in default handlers preventing OOM exceptions to be handled correctly.
Outputis constructed here anyway.This is needed for MME on SM