[python] fix last token fetch logic #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddvenk
approved these changes
Oct 9, 2024
sindhuvahinis
added a commit
to sindhuvahinis/djl-serving
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When exception occurs in inference, we catch it and set the last token as dummy token. So atleast one token should be set, even if exception occurred.
But to check whether last_token_index is set or not, we check
if _last_token_indexwill be false whenlast_token_index=0.This PR reverts the yesterday's PR.
Tested it manually in my ec2 machine