[vllm] Validate speculative model config #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindhuvahinis
approved these changes
Oct 2, 2024
| def validate_speculative_model(self): | ||
| if self.speculative_model is not None and not self.use_v2_block_manager: | ||
| raise ValueError( | ||
| "Speculative decoding requires usage of the V2 block manager. Enable it with option.use_v2_block_manager=true." |
There was a problem hiding this comment.
That's actually not true. [EDIT: I was wrong! Check next comment for details]
There was a problem hiding this comment.
Ok, just double-checked. It actually is true. I was confused by the inconsistency between these two pieces of code in vllm v0.6.2:
- https://github.com/vllm-project/vllm/blob/f58d4fccc9b270838be438f5f0db71bea156a56d/vllm/engine/arg_utils.py#L964-L968 - sets the variable with a warning log if not set and it's required
- https://github.com/vllm-project/vllm/blob/7193774b1ff8603ad5bf4598e5efba0d9a39b436/vllm/config.py#L1203-L1206 - throws error if not set and it's required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about