Skip to content

Commit

Permalink
add MPI Engine as generic name for distributed environment (#882)
Browse files Browse the repository at this point in the history
  • Loading branch information
Qing Lan authored Jun 29, 2023
1 parent 85bcd8c commit 36b750b
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@
import ai.djl.engine.EngineProvider;

/** {@code DsEngineProvider} is the DeepSpeed implementation of {@link EngineProvider}. */
public class DsEngineProvider extends PyEngineProvider {
public class MpiEngineProvider extends PyEngineProvider {

/** Constructs a new {@code DsEngineProvider} instance. */
public DsEngineProvider() {
/** Constructs a new {@code MpiEngineProvider} instance. */
public MpiEngineProvider() {
mpiMode = true;
}

/** {@inheritDoc} */
@Override
public String getEngineName() {
return "DeepSpeed";
return "MPI";
}

/** {@inheritDoc} */
Expand All @@ -34,13 +34,23 @@ public int getEngineRank() {
return PyEngine.RANK + 1;
}

/** {@code FtEngineProvider} is the alias of {@link DsEngineProvider}. */
public static final class FtEngineProvider extends DsEngineProvider {
/** {@code FtEngineProvider} is the alias of {@link MpiEngineProvider}. */
public static final class FtEngineProvider extends MpiEngineProvider {

/** {@inheritDoc} */
@Override
public String getEngineName() {
return "FasterTransformer";
}
}

/** {@code DsEngineProvider} is the alias of {@link MpiEngineProvider}. */
public static final class DsEngineProvider extends MpiEngineProvider {

/** {@inheritDoc} */
@Override
public String getEngineName() {
return "DeepSpeed";
}
}
}
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
ai.djl.python.engine.PyEngineProvider
ai.djl.python.engine.DsEngineProvider
ai.djl.python.engine.DsEngineProvider$FtEngineProvider
ai.djl.python.engine.MpiEngineProvider
ai.djl.python.engine.MpiEngineProvider$FtEngineProvider
ai.djl.python.engine.MpiEngineProvider$DsEngineProvider

0 comments on commit 36b750b

Please sign in to comment.