Skip to content

Commit

Permalink
fix: Fix-broken-TestHebrewCalendarInTemporalLeapYear
Browse files Browse the repository at this point in the history
  • Loading branch information
Zeno-sole authored and deepin-ci-robot committed Oct 12, 2023
1 parent 38bc1be commit 2a51196
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 0 deletions.
6 changes: 6 additions & 0 deletions debian/changelog
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
icu (73.2-1deepin1) unstable; urgency=medium

* Fix-broken-TestHebrewCalendarInTemporalLeapYear.

-- LiChengGang <[email protected]> Thu, 12 Oct 2023 10:28:06 +0800

icu (73.2-1) experimental; urgency=medium

* New upstream release.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
From b6b3e89231a623441940889b5badd90f74bdce2b Mon Sep 17 00:00:00 2001
From: Frank Tang <[email protected]>
Date: Mon, 18 Sep 2023 20:20:42 -0700
Subject: [PATCH] ICU-22512 Fix broken TestHebrewCalendarInTemporalLeapYear

Fix broken test mistakenly landed in
https://github.com/unicode-org/icu/pull/2274

Some important steps were missed in the last landing.
---
icu4c/source/test/intltest/caltest.cpp | 2 ++
1 file changed, 2 insertions(+)

Index: icu/source/test/intltest/caltest.cpp
===================================================================
--- icu.orig/source/test/intltest/caltest.cpp
+++ icu/source/test/intltest/caltest.cpp
@@ -3998,6 +3998,7 @@ void CalendarTest::TestHebrewCalendarInT
for (gc.set(startYear, UCAL_JANUARY, 1);
gc.get(UCAL_YEAR, status) <= stopYear;
gc.add(UCAL_DATE, incrementDays, status)) {
+ cal->setTime(gc.getTime(status), status);
if (failure(status, "add/get/set/getTime/setTime incorrect")) return;

int32_t cal_year = cal->get(UCAL_EXTENDED_YEAR, status);
@@ -4006,6 +4007,7 @@ void CalendarTest::TestHebrewCalendarInT
leapTest->set(UCAL_MONTH, 0);
leapTest->set(UCAL_DATE, 1);
// If 10 months after TISHRI is TAMUZ, then it is a leap year.
+ leapTest->add(UCAL_MONTH, 10, status);
hasLeapMonth = leapTest->get(UCAL_MONTH, status) == icu::HebrewCalendar::TAMUZ;
yearForHasLeapMonth = cal_year;
}

1 change: 1 addition & 0 deletions debian/patches/series
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
icudata-stdlibs.patch
icu-73_Fix-broken-TestHebrewCalendarInTemporalLeapYear.patch

0 comments on commit 2a51196

Please sign in to comment.