chore: Update Playwright to v1.51 #2307
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2307 +/- ##
========================================
Coverage 46.81% 46.81%
========================================
Files 710 710
Lines 39249 39249
Branches 9798 9983 +185
========================================
Hits 18375 18375
Misses 20863 20863
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dgodinez-dh
previously approved these changes
Dec 5, 2024
dgodinez-dh
previously approved these changes
Dec 5, 2024
- Should be no breaking changes - Fixes some issues when running locally on Ubuntu 24 - Has some other interesting features, such as the `--only-changed` cli option
- A newer version, has a change in updateSnapshots functionality
mofojed
force-pushed
the
update-playwright-1.49
branch
from
e4128c6 to
a3ff1b1
Compare
mofojed
changed the title
mofojed
commented
Feb 28, 2025
There was a problem hiding this comment.
Kerning seems to be enabled, even though we should be disabling it in font-kerning: none !important. Is the Playwright.css not being loaded?
- The !important was overriding our tnum settings for grid
|
As part of this ticket should also move the Playwright tools to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--only-changedcli option'tnum'option back for grids (we were overriding that setting in our Playwright css file)