Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-17537: Fix Advanced Filter dialog not showing the values list on tree tables #2232

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Sep 20, 2024

Move isValuesTableAvailable getter from IrisGridTableModel to IrisGridTableModelTemplate to make it availalbe in tree table model.
Fixes DH-17537 in enterprise.

Note, this doesn't fix the issue with Advanced Filter on tree tables in Community. JSAPI throws an exception on a treeTable.copy call.

[AdvancedFilterCreator] Unable to open values table Error: java.lang.UnsupportedOperationException: reexport
    at UnsupportedOperationException_0.createError (dh-core.js:1383:10)
    at UnsupportedOperationException_0.initializeBackingError (dh-core.js:1409:46)
    at UnsupportedOperationException_0.Throwable_0 (dh-core.js:1348:8)
    at UnsupportedOperationException_0.Exception_1 (dh-core.js:1433:18)
    at UnsupportedOperationException_0.RuntimeException_1 (dh-core.js:1446:18)
    at new UnsupportedOperationException_0 (dh-core.js:35418:25)
    at Object.lambda$56 (dh-core.js:24457:14)
    at JsTreeTable$lambda$56$Type.fetch_25 [as fetch_1] (dh-core.js:25453:10)
    at Object.$lambda$32_0 (dh-core.js:31972:23)
    at ClientTableState$lambda$32$Type.accept_90 [as accept] (dh-core.js:32707:9)
    at Function.onInvoke_2 (dh-core.js:5068:12)
    at lambda (dh-core.js:174:22)
    at new Promise (<anonymous>)
    at Object.$refetch_2 (dh-core.js:32098:13)
    at JsTreeTable.copy_1 [as copy] (dh-core.js:24514:16)
    at Proxy.valuesTable (IrisGridTableModelTemplate.ts:1519:32)
    at AdvancedFilterCreator.initValuesTable (AdvancedFilterCreator.tsx:212:13)

Filed an issue in Core: deephaven/deephaven-core#6097

@vbabich vbabich self-assigned this Sep 20, 2024
@vbabich vbabich requested review from a team and dgodinez-dh and removed request for a team September 20, 2024 18:12
@vbabich vbabich added this to the September 2024 milestone Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.64%. Comparing base (ec9b41e) to head (aabcde8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2232      +/-   ##
==========================================
+ Coverage   46.61%   46.64%   +0.03%     
==========================================
  Files         692      692              
  Lines       38508    38508              
  Branches     9826     9802      -24     
==========================================
+ Hits        17949    17963      +14     
- Misses      20506    20534      +28     
+ Partials       53       11      -42     
Flag Coverage Δ
unit 46.64% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dgodinez-dh
dgodinez-dh previously approved these changes Sep 20, 2024
dgodinez-dh
dgodinez-dh previously approved these changes Sep 20, 2024
@vbabich vbabich force-pushed the move-isvaluestableavailable-to-tablemodeltemplate branch from 273a2a6 to aabcde8 Compare September 23, 2024 17:14
@vbabich vbabich enabled auto-merge (squash) September 23, 2024 17:21
@vbabich vbabich merged commit 86e16ee into deephaven:main Sep 23, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
@vbabich vbabich deleted the move-isvaluestableavailable-to-tablemodeltemplate branch September 23, 2024 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants