-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use shared ticket for pydeephaven tables #49
base: main
Are you sure you want to change the base?
Conversation
session = deephaven_object.session | ||
|
||
server_url, token = _check_session(session, params) | ||
|
||
session.bind_table(object_id, deephaven_object) | ||
ticket = SharedTicket(b"h/" + object_id.encode("utf-8")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this magic h/
in front?
Also - does this still only work with tables? We can't publish other kinds of tickets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure myself, I saw you made this comment deephaven/deephaven-core#5854 (comment) so I included it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this doesn't work for other tickets at this time. I think that requires some other mechanism that we either don't have or is tricky to do. I tried using publish
(see implementation of publish_table) but it requires a ticket to already be attached to the object. I didn't really investigate beyond that because it seems like something that requires more careful thought. There is some discussion on #38 for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comment
This is one part of #38, specifically using the shared ticked instead of
bind_table
in the case ofpydeephaven
tablesRequires deephaven/web-client-ui#2189
Tested with the following code