Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump the compiler, runtime, and test runtime version to Java 21 #6340

Merged
merged 5 commits into from
Nov 12, 2024
Merged

chore: Bump the compiler, runtime, and test runtime version to Java 21 #6340

merged 5 commits into from
Nov 12, 2024

Conversation

devinrsmith
Copy link
Member

Fixes #3997

@devinrsmith devinrsmith added this to the Triage milestone Nov 6, 2024
@devinrsmith devinrsmith self-assigned this Nov 6, 2024
@devinrsmith
Copy link
Member Author

This is currently failing nightlies when run with Java 11 or 17, with the error

io.deephaven.lang.completion.ChunkerParserTest

java.lang.UnsupportedClassVersionError: io/deephaven/lang/completion/AllTokenIterableImpl has been compiled by a more recent version of the Java Runtime (class file version 65.0), this version of the Java Runtime only recognizes class file versions up to 61.0

@devinrsmith devinrsmith marked this pull request as ready for review November 7, 2024 18:17
@devinrsmith
Copy link
Member Author

GroovyCompile has been updated to fix the UnsupportedClassVersionError error.

@devinrsmith
Copy link
Member Author

Noted gradle/gradle#18824, gradle/gradle#22449 as links related to --add-exports and --release.

@devinrsmith devinrsmith mentioned this pull request Nov 8, 2024
Open
@devinrsmith devinrsmith enabled auto-merge (squash) November 8, 2024 17:58
niloc132
niloc132 reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewing gradle wiring so far, I'm assuming the new tests make sense on their own

buildSrc/src/main/groovy/io.deephaven.java-toolchain-conventions.gradle Outdated Show resolved Hide resolved
buildSrc/src/main/groovy/io.deephaven.java-toolchain-conventions.gradle Outdated Show resolved Hide resolved
rcaudy
rcaudy reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New unit tests LGTM

@devinrsmith devinrsmith merged commit 2df8304 into deephaven:main Nov 12, 2024
17 checks passed
@devinrsmith devinrsmith deleted the nightly/java-21-compiler branch November 12, 2024 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy left review comments

@niloc132 niloc132 niloc132 approved these changes

Assignees

@devinrsmith devinrsmith

Labels
build NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
Triage
Development

Successfully merging this pull request may close these issues.

Unable to compile with 17
3 participants
@devinrsmith @niloc132 @rcaudy