fix: Allows clients to expect that query performance results have been logged before they receive a response #6334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eRecorder to use onSuccess for response delivery if possible. Exclusions: DoExchange subscriptions and async input table operations. Exceptions: batch already used onSuccess.
rcaudy
added
grpc
NoDocumentationNeeded
session
ReleaseNotesNeeded
rcaudy
changed the title
nbauernfeind
previously approved these changes
Nov 4, 2024
…ake sure we're using safelyComplete
…when implementing RPCs via ExportObject
…ve some gratuitous formatting changes
rcaudy
changed the title
|
LGTM, waiting for a ping from @niloc132 before approving in case he wants a final look before the merge. |
nbauernfeind
approved these changes
Nov 5, 2024
nbauernfeind
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer response messaging to
onSuccessfor allExportBuildersthat useQueryPerformanceRecorder. This allows clients to expect that query performance results have been logged before they receive a response.Change summary:
SessionState.ExportBuilderuses that set aQueryPerformanceRecorderto useonSuccessfor response delivery if possibleDoExchangesubscriptions and async input table operationsonSuccess, but completion now happens after performance results are reportedGrpcUtilusage