Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tolerations for model download job #49

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

bd-g
Copy link
Collaborator

@bd-g bd-g commented Nov 5, 2024

Proposed changes

The AWS model download job is coupled with the Engine deployment as currently implemented, and uses the same affinity. This fixes a scheduling issue by also adding the Engine tolerations block to that model download job, to avoid being blocked by node taints.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have tested my changes in my local self-hosted environment
  • I have added necessary documentation (if appropriate)

Further comments

Resolves #48

@bd-g bd-g requested a review from a team as a code owner November 5, 2024 19:32
@bd-g bd-g merged commit 41c841b into main Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart - no toleration for dg-models-aws-efs-models-management
2 participants