Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model removal #42

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Model removal #42

merged 3 commits into from
Sep 25, 2024

Conversation

bd-g
Copy link
Collaborator

@bd-g bd-g commented Sep 25, 2024

Proposed changes

This adds a field to more easily manage model removal for AWS setups that support automatic model management.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have tested my changes in my local self-hosted environment
    • Tested using helm template, as well as tested end-to-end behavior on a test cluster in AWS
  • I have added necessary documentation (if appropriate)

@bd-g bd-g requested a review from a team as a code owner September 25, 2024 17:43
@bd-g bd-g merged commit 4eead5d into main Sep 25, 2024
1 check passed
@bd-g bd-g deleted the brent-george/model-removal branch September 25, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkroll-deepgram jkroll-deepgram jkroll-deepgram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bd-g @jkroll-deepgram