Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onprem sample file comment #37

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fix onprem sample file comment #37

merged 1 commit into from
Aug 2, 2024

Conversation

bd-g
Copy link
Collaborator

@bd-g bd-g commented Aug 2, 2024

Proposed changes

The onprem sample file has a typo that wrongly suggests the engine.modelManager.volumes.customVolumeClaim.name should be a PersistentVolume instead of a PersistentVolumeClaim. This PR addresses that.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • [-] I have tested my changes in my local self-hosted environment
  • I have added necessary documentation (if appropriate)

@bd-g bd-g requested a review from a team as a code owner August 2, 2024 15:05
@bd-g bd-g merged commit 701a967 into main Aug 2, 2024
1 check passed
@bd-g bd-g deleted the brent-george/fix-onprem-sample branch August 2, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkroll-deepgram jkroll-deepgram jkroll-deepgram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bd-g @jkroll-deepgram