Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom annotations to deployments #33

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Allow custom annotations to deployments #33

merged 1 commit into from
Jul 15, 2024

Conversation

bd-g
Copy link
Collaborator

@bd-g bd-g commented Jul 15, 2024

Proposed changes

Allow specifying custom annotations on Deployment templates for organizing clusters.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have tested my changes in my local self-hosted environment
    • Verified that values are respected by running helm template locally
  • I have added necessary documentation (if appropriate)

@bd-g bd-g requested a review from a team as a code owner July 15, 2024 20:57
@bd-g bd-g merged commit c54568c into main Jul 15, 2024
1 check passed
@bd-g bd-g deleted the brent-george/custom-annotations branch July 15, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkroll-deepgram jkroll-deepgram jkroll-deepgram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bd-g @jkroll-deepgram