Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malformed or statement with serviceAccounts #29

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

bd-g
Copy link
Collaborator

@bd-g bd-g commented Jul 14, 2024

Proposed changes

This PR removes a dangling or directive in between another or statement that caused an error when serviceAccount.create was set to false and the outer or statement continued to try and evaluate the next condition.

Fixes #25

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

@bd-g bd-g marked this pull request as ready for review July 15, 2024 14:53
@bd-g bd-g requested a review from a team as a code owner July 15, 2024 14:53
@bd-g bd-g merged commit 5c4222d into main Jul 15, 2024
1 check passed
@bd-g bd-g deleted the brent-george/fix-sa-or-statement branch July 15, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm fails with error when attempting to use service accounts
2 participants