-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-27] Fix EFS Storage Class Mismatch with Name Prefix #28
Conversation
This change fixes a template issue when using AWS EFS as the storage for self-hosted deployments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This shouldn't affect functionality, but it does keep consistent naming across Deepgram resources.
Could you add a line to the CHANGELOG.md under a new header called "Unreleased" describing the change in the specified format there?
I'll get that added. This was impacting functionality in our cluster as we are using Karpenter Autoscaler; the name mismatch prevented karpenter from scheduling the engine pod, so it wouldn't spin up a new node for it. |
That's good to know! This hasn't been explicitly tested with Karpenter, so I wasn't aware of that. Thanks for the heads up! In that case, if you have autoscaling enabled to include the HPA manifests, make sure to explicitly disable the cluster-autoscaler dependency. |
Thank you! I'll cut a release for this later today. Thanks for your patience on the Changelog request. The other open PR in this report will include a few more CI checks to help guide PR submissions to include that 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This change fixes a template issue when using AWS EFS as the storage for self-hosted deployments