-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI and PR template improvements #26
Conversation
Need to add one more commit here to add a simple CI check that the chart CHANGELOG.md is updated whenever changes are made to the chart. |
echo "Old appVersion: $OLD_APP_VERSION" | ||
echo "New appVersion: $NEW_APP_VERSION" | ||
echo "Chart version: $NEW_VERSION" | ||
echo "Chart version should be bumped anytime the application version is bumped." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this bump done manually, or through helm-docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helm-docs just updates the README based on the contents of the Chart.yaml. Ultimately, the source of truth for the version is going to be the Chart.yaml, which needs to be manually edited.
Update scenarios for these versions could include:
- No version bump. We are making changes that we don't want to release yet, but want to merge.
- Bump only the chart version. This could include an update to the templates that doesn't bump the container tags (which map to the Deepgram self hosted release and is what we use for the appVersion)
- Bump both the chart and app version for an update that includes changing the container tags.
Any other combination of version bump, like updating the app version but not chart version, shouldn't be allowed.
a391ca2
to
7b45d4e
Compare
Proposed changes
This change improves the DevOps portion of this repo in the following ways:
chart-releaser-action
will attempt to run if git detects any changes at all in the chart directory.chart-releaser-action
will attempt to run.Types of changes
What types of changes does your code introduce to the Deepgram self-hosted resources?
Checklist