Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong PR mistake #500

Closed
wants to merge 4 commits into from
Closed

Wrong PR mistake #500

wants to merge 4 commits into from

Conversation

fviard
Copy link
Contributor

@fviard fviard commented Jan 27, 2025 •
edited by coderabbitai bot
Loading

Proposed changes

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflows to remove repository-specific conditions
    • Modified WebSocket library version constraints across multiple configuration files
    • Expanded compatibility for websockets package to versions 12.0 and higher

fviard and others added 4 commits January 28, 2025 00:02
@fviard
CI
7d6b759
@fviard
Merge pull request #3 from fviard/withci
46c6ce9 
Withci
@fviard
Fix support for Python WebSocket >=14 while preserving backward compa…
fe6761f 
…tibility

Python websockets did a breaking change with version 14.
"extra_headers" was renamed to "additionnal_headers".
@fviard
Unpin websockets dependency to support at least versions 12, 13 and 14
612879d
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request makes comprehensive changes to the GitHub Actions workflow configurations and the websockets library dependency management. The primary modifications involve removing repository-specific conditional checks in multiple workflow files, allowing these workflows to run on any repository. Additionally, the project's dependency specifications for the websockets library have been updated across different configuration files to use a more flexible version constraint of >=12.0, removing upper version limits and providing greater compatibility.

Changes

File Change Summary
.github/workflows/* Removed if: github.repository == 'deepgram/deepgram-python-sdk' condition from all workflow files, enabling workflows to run on any repository
deepgram/clients/common/v1/abstract_async_websocket.py Updated WebSocket connection type annotation and added version-aware header handling
pyproject.toml Changed websockets dependency from ^12.0 to >=12.0
requirements.txt Updated websockets version from 12.* to >=12.0
setup.py Modified websockets version constraint from >=12.0,<14.0 to >=12.0

Possibly related PRs

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad276e1 and 612879d.

📒 Files selected for processing (11)
  • .github/workflows/check-actionlint.yaml (0 hunks)
  • .github/workflows/check-all.yaml (0 hunks)
  • .github/workflows/check-lint.yaml (0 hunks)
  • .github/workflows/check-mdlint.yaml (0 hunks)
  • .github/workflows/check-shell.yaml (0 hunks)
  • .github/workflows/check-static.yaml (0 hunks)
  • .github/workflows/check-yaml.yaml (0 hunks)
  • deepgram/clients/common/v1/abstract_async_websocket.py (3 hunks)
  • pyproject.toml (1 hunks)
  • requirements.txt (1 hunks)
  • setup.py (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fviard fviard closed this Jan 27, 2025
@fviard fviard changed the title Fix rebase ci Wrong PR mistake Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fviard