Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix windows build #106

Merged
merged 1 commit into from
Nov 5, 2024
Merged

chore: fix windows build #106

merged 1 commit into from
Nov 5, 2024

Conversation

ovesh
Copy link
Contributor

@ovesh ovesh commented Nov 5, 2024

setuptools broken compat, see pypa/setuptools#4600

Error on latest release attempt: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1071695&view=logs&j=535b614b-9e28-51ef-eb67-d0aa83d01d61&t=c0e5205c-8699-555e-ce93-e93093f402f2&l=29576

setuptools not pinned, changed from 73.0.1 to 75.3.0. Hopefully should work, found similar code in other repos.

setuptools broken compat, see pypa/setuptools#4600
@ovesh ovesh requested a review from s22chan November 5, 2024 02:53
Copy link
Collaborator

@s22chan s22chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this gets unmanageable, we can just remove it and let the windows build be slower to make.

@ovesh ovesh merged commit e1754c7 into main Nov 5, 2024
8 checks passed
@ovesh ovesh deleted the chore/fix-windows-build branch November 5, 2024 16:27
ovesh added a commit that referenced this pull request Nov 6, 2024
missed in #106 but msvc9compiler is gone
@ovesh ovesh mentioned this pull request Nov 6, 2024
ovesh added a commit that referenced this pull request Nov 6, 2024
missed in #106 but msvc9compiler is gone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants