Skip to content

WIP #1794 Add stop button to GME compute dashboard #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/common/compute/backends/gme/ExecutorHelper.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,24 @@ define([
return this.get(JOBS_ENDPOINT, webgmeToken);
};

ExecutorHelper.cancelJob = function(jobId, token) {
const endpoint = `/rest/executor/cancel/${jobId}`;

const deferred = Q.defer();
const url = this.url(endpoint);
const req = superagent.post(url);
if (token) {
req.set('Authorization', 'Bearer ' + token);
}
req.end(err => {
if (err) {
return deferred.reject(err);
}
deferred.resolve();
});

return deferred.promise;
};

return ExecutorHelper;
});
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@
<td class="project">unknown</td>
<td class="createdAt">unknown</td>
<td class="status">unknown</td>
<td class="cancel"><span class="oi oi-media-stop" title="Stop" aria-hidden="true"></span></td>
</tr>
11 changes: 8 additions & 3 deletions src/common/compute/backends/gme/dashboard/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,11 @@ define([
};

WorkerDialog.prototype.updateJobItem = function(jobId) {
var job = this.jobs[jobId] || $(WorkerJobItem),
const job = this.jobs[jobId] || $(WorkerJobItem),
info = this.jobsDict[jobId],
createdTime = new Date(info.createTime).getTime(),
clazz = utils.ClassForJobStatus[info.status.toLowerCase()],
status = info.status;
clazz = utils.ClassForJobStatus[info.status.toLowerCase()];
let status = info.status;

job[0].className = `job-tag ${clazz}`;

Expand All @@ -207,6 +207,11 @@ define([
job.find('.status').text(status);

if (!this.jobs[jobId]) {
job.find('.cancel').on('click', async event => {
event.stopPropagation();
event.preventDefault();
await ExecutorHelper.cancelJob(jobId);
});
job.find('.job-id').text('Loading');
job.find('.createdAt').text(utils.getDisplayTime(createdTime));
this.updateJobItemName(jobId);
Expand Down