Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[querier] remove extend end time #4482

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[querier] remove extend end time #4482

merged 1 commit into from
Oct 16, 2023

Conversation

taloric
Copy link
Contributor

@taloric taloric commented Oct 13, 2023

This PR is for:

  • Server

Fixes query end time fixup

Steps to reproduce the bug

  • when use a query like sum(metric) or vector(0)，prometheus engine would add 0 for each query timestamp. then it will return an unexpected timestamp when extend end time.

Changes to fix the bug

  • for query end time, not extend, only extend start time for start%step>loockbackdelta query.

Affected branches

  • main
  • v6.3

@taloric taloric requested a review from sharang October 13, 2023 10:27
@taloric taloric marked this pull request as ready for review October 16, 2023 04:54
@lzf575 lzf575 merged commit 42645a0 into v6.3 Oct 16, 2023
5 checks passed
@lzf575 lzf575 deleted the fix-query-time-63 branch October 16, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzf575 lzf575 lzf575 approved these changes

@sharang sharang Awaiting requested review from sharang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taloric @lzf575