Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent] kafka support topic in produce and fetch #4306

Closed

Conversation

mickeyzzc
Copy link
Contributor

@mickeyzzc mickeyzzc commented Sep 18, 2023

This PR is for:

#4029
#3922

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2023

CLA assistant check
All committers have signed the CLA.

@mickeyzzc mickeyzzc changed the title kafka support topic in produce and fetch [Agent] kafka support topic in produce and fetch Sep 18, 2023
@mickeyzzc
Copy link
Contributor Author

I tried to fix the problem #3922 here as well

@yuanchaoa yuanchaoa requested a review from rvql October 9, 2023 09:06
@yuanchaoa
Copy link
Contributor

@mickeyzzc Note that this pr intersects with your, so you can rebase your pr

#4507

@mickeyzzc mickeyzzc force-pushed the feature-kafka-support-topic branch 5 times, most recently from 9b50e26 to 1133fd8 Compare October 26, 2023 04:58
@Nick-0314
Copy link
Contributor

@liqian1834 here.

@rvql
Copy link
Contributor

rvql commented Dec 5, 2023

@mickeyzzc 这个 mr 的 commit 太多,可以合并成一个

@mickeyzzc
Copy link
Contributor Author

@mickeyzzc 这个 mr 的 commit 太多,可以合并成一个

done

@rvql
Copy link
Contributor

rvql commented Dec 7, 2023

@mickeyzzc 这个 mr 的 commit 太多,可以合并成一个

done

现在有两个 commit,好像带了很多别的代码,麻烦再重新 rebase 一下;另外还要处理一下 check 里的失败

@mickeyzzc
Copy link
Contributor Author

@mickeyzzc 这个 mr 的 commit 太多,可以合并成一个

done

现在有两个 commit,好像带了很多别的代码,麻烦再重新 rebase 一下;另外还要处理一下 check 里的失败

抱歉,近期忙其他事情没有及时跟进问题。不过我已经看到有其他pr在解决同类问题。#4905 。我就不继续重复了。这个pr可以关闭了。
不过我看到历史的pr都是在解决单个问题,比如#4905 只解决了produce版本9的topic name问题。但是还是没有处理fetch 12版本的情况。这可能会成为bug。

@mickeyzzc mickeyzzc closed this Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants