Skip to content

Commit

Permalink
[Querier] modify pod_group_type showtagvalues error #22514
Browse files Browse the repository at this point in the history
 - run automation test(basic & querier_sql) pass
  • Loading branch information
Ericsssss authored and xiaochaoren1 committed Oct 16, 2023
1 parent a9ec769 commit 3d11340
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 24 deletions.
12 changes: 6 additions & 6 deletions server/controller/tagrecorder/const.go
Original file line number Diff line number Diff line change
Expand Up @@ -756,12 +756,12 @@ var RESOURCE_TYPE_TO_NODE_TYPE = map[int]string{
common.VIF_DEVICE_TYPE_POD_GROUP: RESOURCE_TYPE_POD_GROUP,
common.VIF_DEVICE_TYPE_SERVICE: RESOURCE_TYPE_SERVICE,
common.VIF_DEVICE_TYPE_GPROCESS: RESOURCE_TYPE_GPROCESS,
common.VIF_DEVICE_TYPE_POD_GROUP_DEPLOYMENT: RESOURCE_TYPE_CH_POD_GROUP_DEPLOYMENT,
common.VIF_DEVICE_TYPE_POD_GROUP_STATEFULSET: RESOURCE_TYPE_CH_POD_GROUP_STATEFULSET,
common.VIF_DEVICE_TYPE_POD_GROUP_RC: RESOURCE_TYPE_CH_POD_GROUP_RC,
common.VIF_DEVICE_TYPE_POD_GROUP_DAEMON_SET: RESOURCE_TYPE_CH_POD_GROUP_DAEMON_SET,
common.VIF_DEVICE_TYPE_POD_GROUP_REPLICASET_CONTROLLER: RESOURCE_TYPE_CH_POD_GROUP_REPLICASET_CONTROLLER,
common.VIF_DEVICE_TYPE_POD_GROUP_CLONESET: RESOURCE_TYPE_CH_POD_GROUP_CLONESET,
common.VIF_DEVICE_TYPE_POD_GROUP_DEPLOYMENT: RESOURCE_TYPE_POD_GROUP,
common.VIF_DEVICE_TYPE_POD_GROUP_STATEFULSET: RESOURCE_TYPE_POD_GROUP,
common.VIF_DEVICE_TYPE_POD_GROUP_RC: RESOURCE_TYPE_POD_GROUP,
common.VIF_DEVICE_TYPE_POD_GROUP_DAEMON_SET: RESOURCE_TYPE_POD_GROUP,
common.VIF_DEVICE_TYPE_POD_GROUP_REPLICASET_CONTROLLER: RESOURCE_TYPE_POD_GROUP,
common.VIF_DEVICE_TYPE_POD_GROUP_CLONESET: RESOURCE_TYPE_POD_GROUP,
common.VIF_DEVICE_TYPE_IP: RESOURCE_TYPE_IP,
}

Expand Down
53 changes: 35 additions & 18 deletions server/querier/engine/clickhouse/tag/const.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,28 @@
package tag

const (
VIF_DEVICE_TYPE_INTERNET = 0
VIF_DEVICE_TYPE_VM = 1
VIF_DEVICE_TYPE_VROUTER = 5
VIF_DEVICE_TYPE_HOST = 6
VIF_DEVICE_TYPE_DHCP_PORT = 9
VIF_DEVICE_TYPE_POD = 10
VIF_DEVICE_TYPE_POD_SERVICE = 11
VIF_DEVICE_TYPE_REDIS_INSTANCE = 12
VIF_DEVICE_TYPE_RDS_INSTANCE = 13
VIF_DEVICE_TYPE_POD_NODE = 14
VIF_DEVICE_TYPE_LB = 15
VIF_DEVICE_TYPE_NAT_GATEWAY = 16
VIF_DEVICE_TYPE_POD_GROUP = 101
VIF_DEVICE_TYPE_SERVICE = 102
VIF_DEVICE_TYPE_GPROCESS = 120
VIF_DEVICE_TYPE_IP = 255
VIF_DEVICE_TYPE_INTERNET = 0
VIF_DEVICE_TYPE_VM = 1
VIF_DEVICE_TYPE_VROUTER = 5
VIF_DEVICE_TYPE_HOST = 6
VIF_DEVICE_TYPE_DHCP_PORT = 9
VIF_DEVICE_TYPE_POD = 10
VIF_DEVICE_TYPE_POD_SERVICE = 11
VIF_DEVICE_TYPE_REDIS_INSTANCE = 12
VIF_DEVICE_TYPE_RDS_INSTANCE = 13
VIF_DEVICE_TYPE_POD_NODE = 14
VIF_DEVICE_TYPE_LB = 15
VIF_DEVICE_TYPE_NAT_GATEWAY = 16
VIF_DEVICE_TYPE_POD_GROUP = 101
VIF_DEVICE_TYPE_SERVICE = 102
VIF_DEVICE_TYPE_GPROCESS = 120
VIF_DEVICE_TYPE_POD_GROUP_DEPLOYMENT = 130
VIF_DEVICE_TYPE_POD_GROUP_STATEFULSET = 131
VIF_DEVICE_TYPE_POD_GROUP_RC = 132
VIF_DEVICE_TYPE_POD_GROUP_DAEMON_SET = 133
VIF_DEVICE_TYPE_POD_GROUP_REPLICASET_CONTROLLER = 134
VIF_DEVICE_TYPE_POD_GROUP_CLONESET = 135
VIF_DEVICE_TYPE_IP = 255
)

const (
Expand Down Expand Up @@ -70,8 +76,19 @@ var AutoPodGroupMap = map[string]int{
}

var AutoServiceMap = map[string]int{
"pod_group": VIF_DEVICE_TYPE_POD_GROUP,
"service": VIF_DEVICE_TYPE_SERVICE,
"pod_group": VIF_DEVICE_TYPE_POD_GROUP,
"deployment": VIF_DEVICE_TYPE_POD_GROUP_DEPLOYMENT,
"stateful_set": VIF_DEVICE_TYPE_POD_GROUP_STATEFULSET,
"replication_controller": VIF_DEVICE_TYPE_POD_GROUP_RC,
"daemon_set": VIF_DEVICE_TYPE_POD_GROUP_DAEMON_SET,
"replica_set_controller": VIF_DEVICE_TYPE_POD_GROUP_REPLICASET_CONTROLLER,
"clone_set": VIF_DEVICE_TYPE_POD_GROUP_CLONESET,
"service": VIF_DEVICE_TYPE_SERVICE,
}

var PodGroupTypeSlice = []string{
"deployment", "stateful_set", "replication_controller", "daemon_set",
"replica_set_controller", "clone_set",
}

var NoLanguageTag = []string{
Expand Down
4 changes: 4 additions & 0 deletions server/querier/engine/clickhouse/tag/description.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"context"
"errors"
"fmt"
"golang.org/x/exp/slices"
"regexp"
"strconv"
"strings"
Expand Down Expand Up @@ -701,6 +702,9 @@ func GetTagResourceValues(db, table, rawSql string) (*common.Result, []string, e
"auto_service": AutoServiceMap,
}
for resourceKey, resourceType := range autoMap[tag] {
if slices.Contains(PodGroupTypeSlice, resourceKey) {
continue
}
resourceId := resourceKey + "_id"
resourceName := resourceKey + "_name"
if resourceKey == "service" {
Expand Down

0 comments on commit 3d11340

Please sign in to comment.