Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create .gitignore file #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Create .gitignore file #3

wants to merge 3 commits into from

Conversation

orestkon
Copy link

@orestkon orestkon commented Aug 28, 2017 •
edited
Loading

No description provided.

dionyziz
dionyziz requested changes Aug 28, 2017
View reviewed changes
Copy link
Member

@dionyziz dionyziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new line at end of file

orestkon
orestkon commented Aug 28, 2017
View reviewed changes
Copy link
Author

@orestkon orestkon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part of the StandardJS linter usage? Is this why this new line was a problem? Or is there another reason?

@dionyziz
Copy link
Member

JS linter is about JS. This is not a JS file. It's standard practice to end text files with a new line, especially in source code.

@dionyziz
Copy link
Member

Squash your commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dionyziz dionyziz dionyziz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orestkon @dionyziz