Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some ticket buyer params #2456

Closed
wants to merge 1 commit into from

Conversation

vufon
Copy link

@vufon vufon commented Jan 17, 2025

Related issue: #2455
1. Add param maxticketprice
Add the parameter maxticketprice to enable control over halting ticket purchases when ticket prices are excessively high
The parameter can be configured in the configuration file with the name: ticketbuyer.maxticketprice

  • If value = 0 (default value): The system will proceed with ticket purchases as it did previously
  • if value < 0: param error
  • if value > 0: The system will cease ticket purchases if the ticket price surpasses the specified threshold

2. Shorten the ticketbuyer.balancetomaintainabsolute param name
The parameter name was unnecessarily long, so I have adjusted it to 'ticketbuyer.balancetomaintain.'
The old name remains supported and valid for backward compatibility. However, there will be a notification about updating to the new param name
warning msg:
“ DCRW: The 'ticketbuyer.balancetomaintainabsolute' attribute in the config file is outdated. You should update it to 'ticketbuyer.balancetomaintain'”

…oo high. Shorten balancetomaintainabsolute param
@jholdstock
Copy link
Member

Thanks for your contribution. I'd recommend splitting this into two PRs because these are two distinct changes which can be discussed/reviewed/merged separately without blocking each other.

@vufon
Copy link
Author

vufon commented Jan 22, 2025

Thanks for your contribution. I'd recommend splitting this into two PRs because these are two distinct changes which can be discussed/reviewed/merged separately without blocking each other.

Yes, I got it. I will separate into 2 PRs

@vufon vufon closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants