Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxc/binance: Better error message #3106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

libxc/binance: Better error message #3106

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
460d1be
libxc/binance: Better error message
martonp Dec 3, 2024
dd21473
Joe review and other logging fixes
martonp Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion client/mm/libxc/binance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,8 +1330,12 @@ func (bnc *binance) request(ctx context.Context, method, endpoint string, query,
}
if err := dexnet.Do(req, thing, dexnet.WithSizeLimit(1<<24), dexnet.WithErrorParsing(&errPayload)); err != nil {
bnc.log.Errorf("request error from endpoint %s %q with query = %q, body = %q", method, endpoint, queryString, bodyString)
return fmt.Errorf("%w, bn code = %d, msg = %q", err, errPayload.Code, errPayload.Msg)
if errPayload.Msg != "" {
return fmt.Errorf("Binance error: %v", errPayload.Msg)
}
return err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could include the errPayload.Code in the log above maybe? Or is it logged somewhere else?

}

return nil
}

Expand Down
Loading