Skip to content

Commit

Permalink
app: resolve eslint 8 dep errors with Node 8
Browse files Browse the repository at this point in the history
This resolves a build error encountered with Node 18, but is apparently
related to the version of eslint-config-standard we were using that was
not quite compatible with eslint 8.

 @babel/core                        ^7.17.2  →  ^7.17.10
 @babel/plugin-transform-runtime    ^7.17.0  →  ^7.17.10
 @babel/preset-env                 ^7.16.11  →  ^7.17.10
 @babel/runtime                     ^7.17.8  →   ^7.17.9
 @typescript-eslint/eslint-plugin   ^5.15.0  →   ^5.23.0
 @typescript-eslint/parser          ^5.15.0  →   ^5.23.0
 babel-loader                        ^8.2.3  →    ^8.2.5
 css-loader                          ^6.6.0  →    ^6.7.1
 eslint                             ^8.11.0  →   ^8.15.0
 eslint-config-standard             ^16.0.3  →   ^17.0.0
 eslint-plugin-import               ^2.25.4  →   ^2.26.0
 mini-css-extract-plugin             ^2.5.3  →    ^2.6.0
 sass                               ^1.49.7  →   ^1.51.0
 stylelint                          ^14.5.0  →   ^14.8.2
 stylelint-webpack-plugin            ^3.1.1  →    ^3.2.0
 ts-loader                           ^9.2.8  →    ^9.3.0
 typescript                          ^4.6.2  →    ^4.6.4
 webpack                            ^5.69.0  →   ^5.72.1

This also disables the eslint "object-shorthand" error.
We could use the "consistent" option instead of disabling since there
are only a handful of violations in that mode, but it seems silly.
  • Loading branch information
chappjc committed May 25, 2022
1 parent b2ebd32 commit fcea466
Show file tree
Hide file tree
Showing 9 changed files with 1,013 additions and 919 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Check out source
uses: actions/checkout@v3
- name: Install Linters
run: "curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.45.0"
run: "curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.46.1"

- name: Test
env:
Expand All @@ -30,7 +30,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 17.x]
node-version: [16.x, 18.x]
steps:
- uses: actions/checkout@v3
- name: Use nodejs ${{ matrix.node-version }}
Expand Down
3 changes: 2 additions & 1 deletion client/webserver/site/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ module.exports = {
'no-console': ['off'],
'no-alert': 'error',
'no-eval': 'error',
'no-implied-eval': 'error'
'no-implied-eval': 'error',
'object-shorthand': 'off'
}
}
1,869 changes: 981 additions & 888 deletions client/webserver/site/package-lock.json

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions client/webserver/site/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,34 +15,34 @@
"author": "The Decred developers",
"license": "Blue Oak 1.0.0",
"devDependencies": {
"@babel/core": "^7.17.2",
"@babel/plugin-transform-runtime": "^7.17.0",
"@babel/preset-env": "^7.16.11",
"@babel/core": "^7.17.10",
"@babel/plugin-transform-runtime": "^7.17.10",
"@babel/preset-env": "^7.17.10",
"@babel/preset-typescript": "^7.16.7",
"@babel/runtime": "^7.17.8",
"@typescript-eslint/eslint-plugin": "^5.15.0",
"@typescript-eslint/parser": "^5.15.0",
"babel-loader": "^8.2.3",
"@babel/runtime": "^7.17.9",
"@typescript-eslint/eslint-plugin": "^5.23.0",
"@typescript-eslint/parser": "^5.23.0",
"babel-loader": "^8.2.5",
"bootstrap": "^5.1.3",
"clean-webpack-plugin": "^4.0.0",
"css-loader": "^6.6.0",
"css-loader": "^6.7.1",
"css-minimizer-webpack-plugin": "^3.4.1",
"eslint": "^8.11.0",
"eslint-config-standard": "^16.0.3",
"eslint-plugin-import": "^2.25.4",
"eslint": "^8.15.0",
"eslint-config-standard": "^17.0.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^6.0.0",
"eslint-webpack-plugin": "^3.1.1",
"mini-css-extract-plugin": "^2.5.3",
"sass": "^1.49.7",
"mini-css-extract-plugin": "^2.6.0",
"sass": "^1.51.0",
"sass-loader": "^12.6.0",
"stylelint": "^14.5.0",
"stylelint": "^14.8.2",
"stylelint-config-standard": "^25.0.0",
"stylelint-config-standard-scss": "^3.0.0",
"stylelint-webpack-plugin": "^3.1.1",
"ts-loader": "^9.2.8",
"typescript": "^4.6.2",
"webpack": "^5.69.0",
"stylelint-webpack-plugin": "^3.2.0",
"ts-loader": "^9.3.0",
"typescript": "^4.6.4",
"webpack": "^5.72.1",
"webpack-bundle-analyzer": "^4.5.0",
"webpack-cli": "^4.9.2",
"webpack-merge": "^5.8.0"
Expand Down
4 changes: 2 additions & 2 deletions client/webserver/site/src/html/bodybuilder.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<link rel="icon" href="/img/favicon.png?v=z8A71BD">
<meta name="description" content="Decred DEX Client Web Portal">
<title>{{.Title}}</title>
<link href="/css/style.css?v=z8A71BD" rel="stylesheet">
<link href="/css/style.css?v=lDtQNP" rel="stylesheet">
</head>
<body {{if .UserInfo.DarkMode}} class="dark"{{end}}>
<div class="popup-notes" id="popupNotes">
Expand Down Expand Up @@ -85,7 +85,7 @@
{{end}}

{{define "bottom"}}
<script src="/js/entry.js?v=z8A71BD"></script>
<script src="/js/entry.js?v=lDtQNP"></script>
</body>
</html>
{{end}}
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<link rel="icon" href="/img/favicon.png?v=z8A71BD">
<meta name="description" content="Decred DEX Client Web Portal">
<title>{{.Title}}</title>
<link href="/css/style.css?v=z8A71BD" rel="stylesheet">
<link href="/css/style.css?v=lDtQNP" rel="stylesheet">
</head>
<body {{if .UserInfo.DarkMode}} class="dark"{{end}}>
<div class="popup-notes" id="popupNotes">
Expand Down Expand Up @@ -85,7 +85,7 @@
{{end}}

{{define "bottom"}}
<script src="/js/entry.js?v=z8A71BD"></script>
<script src="/js/entry.js?v=lDtQNP"></script>
</body>
</html>
{{end}}
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<link rel="icon" href="/img/favicon.png?v=z8A71BD">
<meta name="description" content="Decred DEX Client Web Portal">
<title>{{.Title}}</title>
<link href="/css/style.css?v=z8A71BD" rel="stylesheet">
<link href="/css/style.css?v=lDtQNP" rel="stylesheet">
</head>
<body {{if .UserInfo.DarkMode}} class="dark"{{end}}>
<div class="popup-notes" id="popupNotes">
Expand Down Expand Up @@ -85,7 +85,7 @@
{{end}}

{{define "bottom"}}
<script src="/js/entry.js?v=z8A71BD"></script>
<script src="/js/entry.js?v=lDtQNP"></script>
</body>
</html>
{{end}}
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<link rel="icon" href="/img/favicon.png?v=z8A71BD">
<meta name="description" content="Decred DEX Client Web Portal">
<title>{{.Title}}</title>
<link href="/css/style.css?v=z8A71BD" rel="stylesheet">
<link href="/css/style.css?v=lDtQNP" rel="stylesheet">
</head>
<body {{if .UserInfo.DarkMode}} class="dark"{{end}}>
<div class="popup-notes" id="popupNotes">
Expand Down Expand Up @@ -85,7 +85,7 @@
{{end}}

{{define "bottom"}}
<script src="/js/entry.js?v=z8A71BD"></script>
<script src="/js/entry.js?v=lDtQNP"></script>
</body>
</html>
{{end}}
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<link rel="icon" href="/img/favicon.png?v=z8A71BD">
<meta name="description" content="Decred DEX Client Web Portal">
<title>{{.Title}}</title>
<link href="/css/style.css?v=z8A71BD" rel="stylesheet">
<link href="/css/style.css?v=lDtQNP" rel="stylesheet">
</head>
<body {{if .UserInfo.DarkMode}} class="dark"{{end}}>
<div class="popup-notes" id="popupNotes">
Expand Down Expand Up @@ -85,7 +85,7 @@
{{end}}

{{define "bottom"}}
<script src="/js/entry.js?v=z8A71BD"></script>
<script src="/js/entry.js?v=lDtQNP"></script>
</body>
</html>
{{end}}

0 comments on commit fcea466

Please sign in to comment.